Skip to content

Remove Invalid WebMvcConfigurer from Sample Documentation #6850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

adamzimny
Copy link

Obvious Fix
Fixes gh-6809

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 8, 2019
@rwinch
Copy link
Member

rwinch commented May 13, 2019

Thanks for the PR! Since this is the hello world (minimal sample) we can remove extends WebSecurityConfigurerAdapter as well. Can you please update the PR to do that?

@rwinch rwinch added in: docs An issue in Documentation or samples type: bug A general bug status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels May 13, 2019
@adamzimny
Copy link
Author

Hi Rob,

you are right that extends WebSecurityConfigurerAdapter is not needed in the example itself. But if you read on and get to chapter 6.3 (and 6.4 and 6.5) then these chapters refer to the hello world example and explain why we extend from WebSecurityConfigurerAdapter and how it's functionality can be used.
This is actually how I came across the issue, I copy/pasted the hello world code snippet to my application, then continued reading and then at chapter 6.3 things no longer made much sense.

@rwinch
Copy link
Member

rwinch commented May 20, 2019

I think that along with that we should update the documentation to explain that when extending WebSecurityConfigurerAdapter is needed too (i.e. when we need to modify the default behavior of web based security).

@adamzimny
Copy link
Author

This is explained in chapters 6.2 - 6.5. You may be right that this documentation fragment is not perfect and it could use some refactoring. But the intention of this patch is just to fix an obvious bug - wrong class name used in the example.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 29, 2019
@jzheaux jzheaux self-assigned this Aug 17, 2019
@pivotal-issuemaster
Copy link

@adamzimny Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@adamzimny Thank you for signing the Contributor License Agreement!

@rwinch rwinch changed the title Documentation: fix Hello Web Security example Remove Invalid WebMvcConfigurer from Sample Documentation Aug 19, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Aug 22, 2019

Closed in favor of 362356d

@jzheaux jzheaux closed this Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: feedback-provided Feedback has been provided type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants