-
Notifications
You must be signed in to change notification settings - Fork 6k
Remove Invalid WebMvcConfigurer from Sample Documentation #6850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! Since this is the hello world (minimal sample) we can remove |
Hi Rob, you are right that |
I think that along with that we should update the documentation to explain that when extending |
This is explained in chapters 6.2 - 6.5. You may be right that this documentation fragment is not perfect and it could use some refactoring. But the intention of this patch is just to fix an obvious bug - wrong class name used in the example. |
@adamzimny Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@adamzimny Thank you for signing the Contributor License Agreement! |
Closed in favor of 362356d |
Obvious Fix
Fixes gh-6809