Skip to content

Move log statement in SessionRegistryImpl #6979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Move log statement in SessionRegistryImpl #6979

merged 1 commit into from
Jun 13, 2019

Conversation

jbrokamp
Copy link

Moved a log statement in SessionRegistryImpl#registerNewSession after removeSessionInformation() is called for comprehensible output to the logger.

The log statements are now printed in the same order as the logic is executed. Before the change, this could be confusing when debugging an application, since it seemed that the registered session was immediately removed when only looking at the logs.

Before:

> Registering session 500B7FEE4F10F1CFD5C69561FB40C2EC, for principal examplePrincipal
> Removing session 500B7FEE4F10F1CFD5C69561FB40C2EC from principal's set of registered sessions
> Removing principal examplePrincipal from registry

After:

> Removing session E40C41AD72989210A64B1CA2436D7A54 from principal's set of registered sessions
> Removing principal examplePrincipal from registry
> Registering session E40C41AD72989210A64B1CA2436D7A54, for principal examplePrincipal

NB: I did not create a ticket for this.

Moved after removeSessionInformation() is called for comprehensible output to log file. The log statements are now written in correct order. Before the change, this could be confusing when debugging an application, since it seemed that the registered session was immediately removed when only looking at the logs.
@pivotal-issuemaster
Copy link

@joos-edia Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 12, 2019
@pivotal-issuemaster
Copy link

@joos-edia Thank you for signing the Contributor License Agreement!

@rwinch rwinch changed the title Move log statement in SessionRegistryImpl.java Move log statement in SessionRegistryImpl Jun 13, 2019
@rwinch rwinch self-assigned this Jun 13, 2019
@rwinch rwinch added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 13, 2019
@rwinch rwinch added this to the 5.2.0.M3 milestone Jun 13, 2019
@rwinch rwinch merged commit 0e74622 into spring-projects:master Jun 13, 2019
@rwinch
Copy link
Member

rwinch commented Jun 13, 2019

Thanks for the PR @joos-edia! This is now merged into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants