Fix blocking in ServletOAuth2AuthorizedClientExchangeFilterFunction #7037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwinch
reviewed
Jul 23, 2019
| // which is a blocking I/O and therefore triggers BlockHound to error. | ||
| // The following code forces the initialization of the cache, which ultimately calls | ||
| // 'com.fasterxml.jackson.databind.DeserializationContext.hasValueDeserializerFor()'. | ||
| new MappingJackson2HttpMessageConverter().canRead( |
There was a problem hiding this comment.
At minimum this could be simplified to Map.class.getPackage();
jgrandja
force-pushed
the
gh-6589-oauth2-client-non-block
branch
from
55396c8 to
70df9b5
Compare
jgrandja
added
in: oauth2
rwinch
approved these changes
Jul 25, 2019
bsideup
reviewed
Jul 26, 2019
| // it attempts to java.lang.Package.loadManifest() which is blocking I/O and triggers BlockHound to error. | ||
| // The following code forces the loading of the manifest. | ||
| // NOTE: This is an issue with JDK 8. It's been tested on JDK 10 and works fine w/o this workaround. | ||
| Class.class.getPackage(); |
There was a problem hiding this comment.
There was a problem hiding this comment.
@bsideup I'm curious...It does block, so why would we whitelist it?
|
Merged via 4ca9e15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-6589
Related spring-framework#23361