Add support to prevent authentication when user is locked, disabled o… #7119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
eleftherias
suggested changes
Jul 24, 2019
There was a problem hiding this comment.
Thaks for the PR, @eddumelendez! I have left some feedback inline. Would you also consider changing the commit message to something shorter? One idea is "Prevent authentication of inactive user for reactive apps"
...pringframework/security/authentication/AbstractUserDetailsReactiveAuthenticationManager.java
Show resolved
Hide resolved
...pringframework/security/authentication/AbstractUserDetailsReactiveAuthenticationManager.java
Show resolved
Hide resolved
...ingframework/security/authentication/UserDetailsRepositoryReactiveAuthenticationManager.java
Outdated
Show resolved
Hide resolved
...amework/security/authentication/UserDetailsRepositoryReactiveAuthenticationManagerTests.java
Show resolved
Hide resolved
...ingframework/security/authentication/UserDetailsRepositoryReactiveAuthenticationManager.java
Show resolved
Hide resolved
...amework/security/authentication/UserDetailsRepositoryReactiveAuthenticationManagerTests.java
Outdated
Show resolved
Hide resolved
...amework/security/authentication/UserDetailsRepositoryReactiveAuthenticationManagerTests.java
Outdated
Show resolved
Hide resolved
...amework/security/authentication/UserDetailsRepositoryReactiveAuthenticationManagerTests.java
Outdated
Show resolved
Hide resolved
eleftherias
added
in: web
Currently, reactive applications doesn't perform validation when user is locked, disabled or expired. This commit introduces these validations. Fixes spring-projectsgh-7113
|
Hi @eleftherias I have solved the comments. Thanks for the feedback |
eleftherias
suggested changes
Jul 25, 2019
There was a problem hiding this comment.
Thank you for the quick update @eddumelendez! I have left a couple more comments inline.
...pringframework/security/authentication/AbstractUserDetailsReactiveAuthenticationManager.java
Outdated
Show resolved
Hide resolved
...amework/security/authentication/UserDetailsRepositoryReactiveAuthenticationManagerTests.java
Show resolved
Hide resolved
|
@eleftherias new commits has been submitted with the changes. |
|
Thanks for the PR @eddumelendez! This is now merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r expired for reactive apps
Currently, reactive applications doesn't perform validation when user
is locked, disabled or expired. This commit introduces these validations.
Fixes gh-7113