Skip to content

Downgrade modifier from public to protected #7180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2019
Merged

Downgrade modifier from public to protected #7180

merged 1 commit into from
Aug 4, 2019

Conversation

sothavirak
Copy link
Contributor

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 3, 2019
@jzheaux jzheaux self-assigned this Aug 3, 2019
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 3, 2019
@jzheaux jzheaux added this to the 5.2.0.M4 milestone Aug 3, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Aug 3, 2019

@sothavirak Thanks for the PR!

In preparation for merging, would you please update your commit message to include the issue that you fixed as well? Something like:

Downgrade AuthenticationFilter modifier

Fixes gh-7177

@sothavirak
Copy link
Contributor Author

@jzheaux done with the commit messages amendment.

@jzheaux
Copy link
Contributor

jzheaux commented Aug 3, 2019

Great, @sothavirak. In preparation for merging, would you please squash your commits?

Since your PR contains a merge commit, it appears that your branch may also need to rebase with master. Let me know if you get stuck on these points - happy to help.

@sothavirak
Copy link
Contributor Author

@jzheaux done with the squash, might need a little help on the rebase branch with master.

@jzheaux jzheaux merged commit a5cfd9f into spring-projects:master Aug 4, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Aug 4, 2019

Thanks for the PR, @sothavirak, and welcome to the Spring community! This is now merged into master.

We'd love to see more contributions from you! Please check out tickets with the label "status: ideal-for-contribution"

@sothavirak sothavirak deleted the gh-7177 branch August 29, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.M4
Development

Successfully merging this pull request may close these issues.
3 participants
@sothavirak @jzheaux @spring-projects-issues