Skip to content

Dispose default Scheduler #7493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.springframework.beans.factory.DisposableBean;
import reactor.core.publisher.Mono;
import reactor.core.scheduler.Scheduler;
import reactor.core.scheduler.Schedulers;
Expand Down Expand Up @@ -45,7 +46,7 @@
* @author Eddú Meléndez
* @since 5.2
*/
public abstract class AbstractUserDetailsReactiveAuthenticationManager implements ReactiveAuthenticationManager {
public abstract class AbstractUserDetailsReactiveAuthenticationManager implements ReactiveAuthenticationManager, DisposableBean {

protected final Log logger = LogFactory.getLog(getClass());

Expand All @@ -55,7 +56,8 @@ public abstract class AbstractUserDetailsReactiveAuthenticationManager implement

private ReactiveUserDetailsPasswordService userDetailsPasswordService;

private Scheduler scheduler = Schedulers.newParallel("password-encoder");
Scheduler scheduler = Schedulers.newParallel("password-encoder");
private boolean defaultScheduler = true;

private UserDetailsChecker preAuthenticationChecks = user -> {
if (!user.isAccountNonLocked()) {
Expand Down Expand Up @@ -138,6 +140,10 @@ public void setPasswordEncoder(PasswordEncoder passwordEncoder) {
*/
public void setScheduler(Scheduler scheduler) {
Assert.notNull(scheduler, "scheduler cannot be null");
if (this.defaultScheduler) {
this.defaultScheduler = false;
this.scheduler.dispose();
}
this.scheduler = scheduler;
}

Expand Down Expand Up @@ -171,4 +177,10 @@ public void setPostAuthenticationChecks(UserDetailsChecker postAuthenticationChe
*/
protected abstract Mono<UserDetails> retrieveUser(String username);

@Override
public void destroy() {
if (this.defaultScheduler) {
this.scheduler.dispose();
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
import org.springframework.security.core.userdetails.UserDetails;
import org.springframework.security.crypto.password.PasswordEncoder;
import reactor.core.publisher.Mono;
import reactor.core.scheduler.Scheduler;
import reactor.core.scheduler.Schedulers;
import reactor.test.StepVerifier;

/**
Expand Down Expand Up @@ -136,4 +138,33 @@ public void authenticateWhenPasswordEncoderAndFailThenFail() {
.expectError(BadCredentialsException.class)
.verify();
}

@Test
public void destroyWhenDefaultSchedulerThenShouldDispose() {
assertThat(manager.scheduler.isDisposed()).isFalse();
manager.destroy();
assertThat(manager.scheduler.isDisposed())
.as("default Scheduler should be disposed")
.isTrue();
}

@Test
public void destroyWhenCustomSchedulerThenShouldNotDispose() {
manager.setScheduler(Schedulers.parallel());
manager.destroy();
assertThat(manager.scheduler.isDisposed())
.as("custom Scheduler should not be disposed")
.isFalse();
}

@Test
public void setSchedulerWhenSetCustomSchedulerThenDisposeDefault() {
Scheduler defaultScheduler = manager.scheduler;
assertThat(defaultScheduler.isDisposed()).isFalse();
manager.setScheduler(Schedulers.parallel());
assertThat(defaultScheduler.isDisposed())
.as("default Scheduler should be disposed")
.isTrue();
}

}