Skip to content

Back compatibility support for object_id_identity #7622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nucatus
Copy link

@nucatus nucatus commented Nov 5, 2019

Back compatibility is broken in case of data models where the object_id_identity is of type BIGINT. In order to add support for this type, the AclClassIdUtils class is modified to support the conversion of the BigInteger type to Long.

#7621

Back compatibility is broken in case of data models where the object_id_identity is of type `BIGINT`. In order to add support for this type, the `AclClassIdUtils` class is modified to support the conversion of the BigInteger type to Long.
@pivotal-issuemaster
Copy link

@nucatus Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 5, 2019
@pivotal-issuemaster
Copy link

@nucatus Thank you for signing the Contributor License Agreement!

@eleftherias eleftherias added in: acl An issue in spring-security-acl and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 12, 2019
@jzheaux jzheaux self-assigned this Nov 22, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Nov 26, 2019

Thanks for the PR, @nucatus! And for your patience while I looked into some related issues.

Actually, it's probably wrong that AclClassIdUtils is getting called at all if you aren't using class_id_type, basic on AclClassIdUtils's JavaDoc. Would you be interested in modifying your PR to something along the lines of #7598 (comment)?

@jzheaux jzheaux removed their assignment Dec 6, 2021
@eleftherias eleftherias self-assigned this Dec 7, 2021
@eleftherias
Copy link
Contributor

I'm going to close this PR as a duplicate because the associated issue (#7621) has been fixed via #8538 in 4ab9da1.

@eleftherias eleftherias closed this Dec 8, 2021
@eleftherias eleftherias added the status: duplicate A duplicate of another issue label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: acl An issue in spring-security-acl status: duplicate A duplicate of another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants