Skip to content

Change default subjectDnRegex pattern in SubjectDnX509PrincipalExtractor to match CN at end of DN #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

michaelpigg
Copy link

Changes subjectDnRegex default pattern from "CN=(.?)," to "CN=(.?)(?:,.)$" to match a CN occurring anywhere in the subject DN field. Added unit test to show that this works and does not break existing unit tests.

@rwinch
Copy link
Member

rwinch commented Jul 25, 2012

Thank you for your submission. Can you please update your pull request to conform to the recently created Contributor Guidelines? I realize that the guidelines were created after the pull request, but in order for me to accept the pull request the guidelines should be followed. For example, single commit per JIRA, associated to a JIRA (I know there is a JIRA but the commit comment should have the JIRA ID as described in the guidelines), create a topic branch that is rebased (not merged), etc.

@rwinch
Copy link
Member

rwinch commented Aug 17, 2012

I have modified the commits myself and pushed them to master. I also modified the regular expression slightly to more eagerly terminate. I used your test cases, so left @michaelpigg as the author on them but updated the commit message to conform to the contributor guidelines. Once again thank you for your submission.

@rwinch rwinch closed this Aug 17, 2012
rwinch pushed a commit that referenced this pull request Oct 30, 2014
Fix "rm -rf" instruictions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants