Skip to content

Add debug logging to Reactive Web #8504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2020
Merged

Conversation

mouellet
Copy link
Contributor

@mouellet mouellet commented May 8, 2020

Goal is to provide insight to devs on:

  • Authentication & Authorization success/failures
  • WebSession & SecurityContext
  • Request matchers, cache & authn/authz flow

Fixes gh-5758

Please feel free to suggest better log messages (they mostly come from the servlet side)!

Goal is to provide insight to devs on:
- Authentication & Authorization success/failures
- WebSession & SecurityContext
- Request matchers, cache & authn/authz flow

Fixes spring-projectsgh-5758
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 8, 2020
@rwinch rwinch self-assigned this May 12, 2020
@rwinch rwinch added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 12, 2020
@rwinch rwinch changed the title Add debug logging Add debug logging to Reactive Web May 12, 2020
@rwinch rwinch added the in: web An issue in web modules (web, webmvc) label May 12, 2020
@rwinch rwinch added this to the 5.4.0-M2 milestone May 12, 2020
@rwinch rwinch merged commit cd08102 into spring-projects:master May 12, 2020
@rwinch
Copy link
Member

rwinch commented May 12, 2020

Thank you @mouellet! This is now merged into master. I believe this is a significant improvement on where things stand today. However, I do want to let you know that we are hoping to revisit our logging story and align with some of the logging changes Spring Framework did in 5.0 (i.e. more targeted logging). In the meantime, this is a drastic improvement to the code today. Thanks again!

@jzheaux jzheaux mentioned this pull request Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Spring-Security logging with Spring-Boot and WebFlux
3 participants