Updated SimpleSavedRequest#getMethod #8686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
in: web
jzheaux
requested changes
Jun 16, 2020
There was a problem hiding this comment.
Thanks for the PR, @sentinalll! I've left some feedback inline.
web/src/test/java/org/springframework/security/web/savedrequest/SimpleSavedRequestTests.java
Show resolved
Hide resolved
web/src/main/java/org/springframework/security/web/savedrequest/SimpleSavedRequest.java
Outdated
Show resolved
Hide resolved
web/src/test/java/org/springframework/security/web/savedrequest/SimpleSavedRequestTests.java
Outdated
Show resolved
Hide resolved
web/src/test/java/org/springframework/security/web/savedrequest/SimpleSavedRequestTests.java
Outdated
Show resolved
Hide resolved
Before: 1. SimpleSavedRequest#getMethod returned null 2. SimpleSavedRequest(SavedRequest request) constructor did not set the method field from request After: 1. SimpleSavedRequest#getMethod returns method property value 2. SimpleSavedRequest(SavedRequest request) constructor sets the method field from request Closes spring-projectsgh-8675
jzheaux
added
status: duplicate
jzheaux
approved these changes
Jul 8, 2020
|
Thanks for the PR, @sentinalll! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Closes gh-8675
I have submitted the CLA