OAuth2AccessTokenResponse.Builder.expiresIn works after withResponse #8766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
benba
force-pushed
the
gh-8702-fix-expiresin
branch
from
8eaa7ec to
5eabbc6
Compare
benba
force-pushed
the
gh-8702-fix-expiresin
branch
from
5eabbc6 to
756c34b
Compare
jgrandja
added
in: oauth2
|
Thanks for the PR @benba FYI, I added a bit of polish to the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OAuth2AccessTokenResponse.Builder.expiresInwas ignored when the Builder was initiated fromwithReponse, becauseOAuth2AccessTokenResponse.expiresAtwas already initiated.This PR reset
OAuth2AccessTokenResponse.expiresAtstatus every timeOAuth2AccessTokenResponse.Builder.expiresInis called.Closes gh-8702
I have submitted the CLA