Skip to content

Add try-with-resources to close stream #9053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2020
Merged

Add try-with-resources to close stream #9053

merged 1 commit into from
Sep 29, 2020

Conversation

MeTPP
Copy link

@MeTPP MeTPP commented Sep 27, 2020

Closes Issue gh-9041

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 27, 2020
@pivotal-issuemaster
Copy link

@MeTPP Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@MeTPP
Copy link
Author

MeTPP commented Sep 27, 2020

@pivotal-issuemaster This is an Obvious Fix

@pivotal-issuemaster
Copy link

@MeTPP This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@jzheaux jzheaux self-assigned this Sep 28, 2020
@jzheaux jzheaux added in: core An issue in spring-security-core type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 28, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Sep 28, 2020

Thanks for the PR, @MeTPP! Will you please amend the commit message to say "Closes gh-9041" instead of "Issue gh-9041"? In this way, GitHub will automatically close the related issue when this PR is merged.

@MeTPP
Copy link
Author

MeTPP commented Sep 29, 2020

Thanks. I edited my commit comment and force-pushed

@jzheaux jzheaux added this to the 5.4.1 milestone Sep 29, 2020
@jzheaux jzheaux merged commit 6d14482 into spring-projects:master Sep 29, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Sep 29, 2020

Thanks, @MeTPP! This is now merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core type: bug A general bug
Projects
None yet
Milestone
5.4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@MeTPP @pivotal-issuemaster @jzheaux @spring-projects-issues @stanislav-malyshau-idf