Use LobHandler in JdbcOAuth2AuthorizedClientService #9070
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
candrews
force-pushed
the
JdbcOAuth2AuthorizedClientService-LobHandler
branch
from
6542724 to
1c86e74
Compare
|
@jgrandja could you please take a look at this PR? I'm eager to work with you to get it merged - thank you! |
|
Apologies for the delay @candrews. I've been very busy with the new Spring Authorization Server. I'll review this early next week. Thanks for your patience. |
jgrandja
added
in: oauth2
jgrandja
requested changes
Oct 21, 2020
There was a problem hiding this comment.
Thanks for the PR @candrews !
I left some feedback for you. The requested changes are minor so this is close to being merged.
Can you please add Closes gh-9070 at the end of the commit message for the LobHandler and Issue gh-9070 at the end of the commit message for the Postgres.sql.
Also, please rebase on master.
.../main/java/org/springframework/security/oauth2/client/JdbcOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/client/JdbcOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/client/JdbcOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/client/JdbcOAuth2AuthorizedClientService.java
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/client/JdbcOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/client/JdbcOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/client/JdbcOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/client/JdbcOAuth2AuthorizedClientService.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/oauth2/client/JdbcOAuth2AuthorizedClientService.java
Show resolved
Hide resolved
LobHandler provides an abstraction for handling large binary fields and large text fields in specific databases, no matter if represented as simple types or Large OBjects. Its use provides compatibility with many databases eliminating the need for custom OAuth2AuthorizedClientParametersMapper and OAuth2AuthorizedClientRowMapper implementations. Closes spring-projectsgh-9070
…vice
Postgres doesn't have a BLOB type, but it does have an equivalent BYTEA
type.
This approach and naming convention follows the convention established
in Spring Session JDBC which has sql for each RDBMS with files names in
the pattern *-{dbname}.sql, for example:
schema-db2.sql
schema-derby.sql
schema-h2.sql
schema-mysql.sql
schema-postgresql.sql
See https://github.com/spring-projects/spring-session/tree/2.3.1.RELEASE/spring-session-jdbc/src/main/resources/org/springframework/session/jdbc
Issue spring-projectsgh-9070
candrews
force-pushed
the
JdbcOAuth2AuthorizedClientService-LobHandler
branch
from
1c86e74 to
2595267
Compare
jgrandja
approved these changes
Oct 22, 2020
jgrandja
pushed a commit
that referenced
this pull request
Oct 22, 2020
…vice
Postgres doesn't have a BLOB type, but it does have an equivalent BYTEA
type.
This approach and naming convention follows the convention established
in Spring Session JDBC which has sql for each RDBMS with files names in
the pattern *-{dbname}.sql, for example:
schema-db2.sql
schema-derby.sql
schema-h2.sql
schema-mysql.sql
schema-postgresql.sql
See https://github.com/spring-projects/spring-session/tree/2.3.1.RELEASE/spring-session-jdbc/src/main/resources/org/springframework/session/jdbc
Issue gh-9070
|
Thank you for this valuable enhancement @candrews ! This is now in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LobHandler provides an abstraction for handling large binary fields and large text
fields in specific databases, no matter if represented as simple types or
Large OBjects.
Its use provides compatibility with many databases eliminating the need
for custom OAuth2AuthorizedClientParametersMapper and
OAuth2AuthorizedClientRowMapper implementations.
This change brings
JdbcOAuth2AuthorizedClientServiceinto alignment with the best practices documented by Spring Framework at https://docs.spring.io/spring-framework/docs/5.2.9.RELEASE/spring-framework-reference/data-access.html#jdbc-lobThe problem that this PR fixes has been raised in a number of issues, including:
#9023
#8862
#8539