Skip to content

Fixes in documentation #9099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2020
Merged

Fixes in documentation #9099

merged 3 commits into from
Oct 12, 2020

Conversation

mluppi
Copy link
Contributor

@mluppi mluppi commented Oct 6, 2020

Changes in CONTRIBUTING.adoc:

  • Syntax corrected
  • Links updated
  • Improved wording of some paragraphs and fixed typos
  • Restored some parts that got lost during conversion to adoc format (see: a8b4385)

Changes in community.adoc:

  • Updated link to CONTRIBUTING.adoc (no longer .md)
  • Corrected name of Stack Overflow according to their trademark guidelines (two words, capital letters)

mluppi added 2 commits October 6, 2020 17:08
@mluppi
Rework CONTRIBUTING.adoc
30e60c2 
Several fixes were applied: Syntax corrected, links updated, improved some paragraphs, restored parts that were removed in the conversion to adoc format (see: a8b4385)
@mluppi
Rework community.adoc
b015486 
Fix link to CONTRIBUTING.adoc and use proper name of Stack Overflow according to their trademark guidelines (two words, capital letters)
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 6, 2020
jzheaux
jzheaux requested changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements, @mluppi! I've left some feedback inline.

@jzheaux jzheaux self-assigned this Oct 6, 2020
@mluppi
Copy link
Contributor Author

mluppi commented Oct 7, 2020

Thanks for the feedback, @jzheaux
I applied all suggested changes.

@jzheaux jzheaux merged commit 78d5ffe into spring-projects:master Oct 12, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Oct 12, 2020

Thanks, @mluppi, for the PR! This is now merged.

@jzheaux jzheaux added this to the 5.5.0-M1 milestone Nov 4, 2020
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux requested changes

Assignees

@jzheaux jzheaux

Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Milestone
5.5.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@mluppi @jzheaux @spring-projects-issues