JwtIssuerValidator handles issuer (iss) claim values as Strings and URLs #9137
Conversation
|
@cmouttet Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@cmouttet Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
cmouttet
force-pushed
the
gh-9136
branch
4 times, most recently
from
f1c1679 to
2dc4e76
Compare
There was a problem hiding this comment.
Thanks for the PR, @cmouttet, and for your patience while I was out of the office.
I've left one piece of feedback inline.
Also, will you please make sure that your comment uses "Closes gh-9136" instead of "Issue gh-9136"? If you do that, then GitHub will link this PR to that issue and also close the ticket when the PR is merged.
|
|
||
| /** | ||
| * Constructs a {@link JwtIssuerValidator} using the provided parameters | ||
| * @param issuer - The issuer that each {@link Jwt} should have. | ||
| */ | ||
| public JwtIssuerValidator(String issuer) { | ||
| Assert.notNull(issuer, "issuer cannot be null"); | ||
| this.validator = new JwtClaimValidator(JwtClaimNames.ISS, issuer::equals); | ||
|
|
||
| Predicate<Object> testClaimValueURL = ( |
There was a problem hiding this comment.
Have you already considered
Predicate<Object> testClaimValue = (claimValue) ->
claimValue != null && issuer.equals(claimValue.toString())as it simplifies the logic?
There was a problem hiding this comment.
Hi Josh, many thanks for your feedback. I simplified the logic as you suggested and pushed a fix-up commit. After the checks succeed I'll squash the commits and change the commit comment having "Closes ...".
- NimbusJwtDecoder uses claim set converters: issuer claim is converted to an URL object - JwtIssuerValidator (created by JwtValidators.createDefaultWithIssuer(String)) wraps a JwtClaimValidator<String> - because of different data types, equal() is always false This change allows both Strings and URLs as values of the issuer Closes spring-projectsgh-9136
|
Thanks, @cmouttet! This is now merged. |
jzheaux
added
in: oauth2
This change allows both Strings and URLs as values of the issuer
Issue gh-9136