Skip to content

Change guard expressions order #9153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

Change guard expressions order #9153

merged 1 commit into from
Oct 27, 2020

Conversation

avpoloz
Copy link
Contributor

@avpoloz avpoloz commented Oct 26, 2020

Check of allowed user sessions count moved to head for avoid unnecessary fetching all user sessions.

Fixes gh-9152

@avpoloz
Change guard expressions order
cc79fff 
Check of allowed user sessions count moved to head for avoid unnecessary fetching all user sessions.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 26, 2020
@eleftherias eleftherias self-assigned this Oct 27, 2020
eleftherias
eleftherias suggested changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ApRobot! This is a nice enhancement. It looks like your branch is slightly behind, could you rebase on the latest master branch and then we can merge this.

@eleftherias eleftherias added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 27, 2020
@avpoloz
Copy link
Contributor Author

avpoloz commented Oct 27, 2020

My fault.) Done.

@avpoloz avpoloz requested a review from eleftherias October 27, 2020 13:08
@eleftherias eleftherias added this to the 5.5.0-M1 milestone Oct 27, 2020
@eleftherias eleftherias merged commit a362ab5 into spring-projects:master Oct 27, 2020
@eleftherias
Copy link
Contributor

Thanks @ApRobot! This is now merged into master.

@eleftherias eleftherias added the status: duplicate A duplicate of another issue label Oct 27, 2020
@avpoloz avpoloz deleted the gh-9152 branch October 27, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherias eleftherias Awaiting requested review from eleftherias

Assignees

@eleftherias eleftherias

Labels
in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.5.0-M1
3 participants
@avpoloz @eleftherias @spring-projects-issues