Skip to content

SecurityWebApplicationContextUtils cleanup gh-8868 #9194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from Nov 13, 2020
Merged

SecurityWebApplicationContextUtils cleanup gh-8868 #9194

merged 2 commits into from Nov 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2020 •
edited by ghost
Loading

Change to cleanup SecurityWebApplicationContextUtils. Based on the recommendation in the tagged issue.

We no longer need to support versions of Spring Framework that old, so we should now call WebApplicationContextUtils.findWebApplicationContext

Closes gh-8868

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 8, 2020
@rwinch rwinch added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 13, 2020
@rwinch rwinch added this to the 5.5.0-M2 milestone Nov 13, 2020
@rwinch rwinch merged commit 4cc3c25 into spring-projects:master Nov 13, 2020
@rwinch
Copy link
Member

rwinch commented Nov 13, 2020

Thanks for the Pull Request! This is now merged into master 😄

@rwinch rwinch assigned ghost Nov 13, 2020
@eleftherias eleftherias mentioned this pull request Jun 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwinch rwinch

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
5.5.0-M2
Development

Successfully merging this pull request may close these issues.

SecurityWebApplicationContextUtils should use WebApplicationContextUtils
2 participants
@rwinch @spring-projects-issues