-
Notifications
You must be signed in to change notification settings - Fork 6k
Expose *InvocationExpressionAttribute classes #9206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The entirety of the expression-based PrePostAdvice interceptor chain is already public with the exception of these two classes. Making these public will allow consumers to build custom PrePostAdvice interceptor implementations on parity with the provided classes, without needing to duplicate code.
@jnfeinstein Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@jnfeinstein Thank you for signing the Contributor License Agreement! |
@rwinch wondering if this might land on your plate 😃 |
I think where this lands is going to depend on what things look like after gh-8996 is completed |
I am not certain they cover the same issue. Does #8996 target reactive method security? |
@jnfeinstein the work for method security was split out into #9350 |
@jnfeinstein no, it doesn't, though the pattern ultimately followed in #9350 may determine what's done for reactive in #9401. I think it's okay to leave this open for the time being since #9350 and #9401 are not resolved. |
Now that #9401 is closed and these classes are deprecated, I think we should leave them be and encourage folks to migrate to |
The entirety of the expression-based PrePostAdvice interceptor chain is already public with the exception of these two classes. Making these public will allow consumers to build custom PrePostAdvice interceptor implementations on parity with the provided classes, without needing to duplicate code.
Per #4841, this should allow downstream consumers who only care about reactive implementations to do so without copying and pasting existing code.