Skip to content

Expose *InvocationExpressionAttribute classes #9206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jnfeinstein
Copy link

@jnfeinstein jnfeinstein commented Nov 16, 2020

The entirety of the expression-based PrePostAdvice interceptor chain is already public with the exception of these two classes. Making these public will allow consumers to build custom PrePostAdvice interceptor implementations on parity with the provided classes, without needing to duplicate code.

Per #4841, this should allow downstream consumers who only care about reactive implementations to do so without copying and pasting existing code.

The entirety of the expression-based PrePostAdvice interceptor
chain is already public with the exception of these two classes.
Making these public will allow consumers to build custom
PrePostAdvice interceptor implementations on parity with the
provided classes, without needing to duplicate code.
@pivotal-issuemaster
Copy link

@jnfeinstein Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 16, 2020
@pivotal-issuemaster
Copy link

@jnfeinstein Thank you for signing the Contributor License Agreement!

@jnfeinstein
Copy link
Author

@rwinch wondering if this might land on your plate 😃

@rwinch
Copy link
Member

rwinch commented Dec 9, 2020

I think where this lands is going to depend on what things look like after gh-8996 is completed

@jnfeinstein
Copy link
Author

I am not certain they cover the same issue. Does #8996 target reactive method security?

@jzheaux
Copy link
Contributor

jzheaux commented Feb 23, 2021

@jnfeinstein the work for method security was split out into #9350

@jnfeinstein
Copy link
Author

@jzheaux does #9350 cover reactive method security? I haven't been able to get a clear answer and I'm not familiar enough with the code to deduce for myself. Happy to close if desired.

@jzheaux
Copy link
Contributor

jzheaux commented Mar 12, 2021

@jnfeinstein no, it doesn't, though the pattern ultimately followed in #9350 may determine what's done for reactive in #9401.

I think it's okay to leave this open for the time being since #9350 and #9401 are not resolved.

@eleftherias eleftherias added the in: core An issue in spring-security-core label Dec 8, 2021
@eleftherias
Copy link
Contributor

I'm going to mark this PR as blocked on #9401.
We should revisit it once #9401 is closed.

@eleftherias eleftherias added status: blocked An issue that's blocked on an external project change and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 8, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Nov 15, 2022

Now that #9401 is closed and these classes are deprecated, I think we should leave them be and encourage folks to migrate to AuthorizationManager.

@jzheaux jzheaux closed this Nov 15, 2022
@jzheaux jzheaux self-assigned this Nov 15, 2022
@jzheaux jzheaux added status: declined A suggestion or change that we don't feel we should currently apply and removed status: blocked An issue that's blocked on an external project change labels Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants