WebFlux oauth2Login with formLogin test #9326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
in: oauth2
jgrandja
requested changes
Jan 6, 2021
There was a problem hiding this comment.
Thanks for the PR @iilkevych. Please see review comments.
Also, please squash commits on next update.
config/src/test/java/org/springframework/security/config/web/server/OAuth2LoginTests.java
Outdated
Show resolved
Hide resolved
config/src/test/java/org/springframework/security/config/web/server/OAuth2LoginTests.java
Outdated
Show resolved
Hide resolved
jgrandja
changed the title
jgrandja
added
in: test
iilkevych
force-pushed
the
master
branch
4 times, most recently
from
898246e to
f98bc29
Compare
…inPageGeneratingWebFilter
|
Thanks for the updates @iilkevych ! This is now in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9318 duplicate
@jgrandja there are a lot of tests for WebFlux and they are not demonstrating issues. They are demonstrating expected behaviour. This test demonstrates how WebFlux handles oauth2Login and formLogin together.