Add setMetadataFilename method to Saml2MetadataFilter #9393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Feb 2, 2021
There was a problem hiding this comment.
Thanks, @GitHanter, for the PR! I've left my feedback inline.
...g/springframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurer.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/saml2/provider/service/web/Saml2MetadataFilter.java
Show resolved
Hide resolved
...c/main/java/org/springframework/security/saml2/provider/service/web/Saml2MetadataFilter.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/saml2/provider/service/web/Saml2MetadataFilter.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/saml2/provider/service/web/Saml2MetadataFilter.java
Outdated
Show resolved
Hide resolved
samples/boot/saml2login/src/main/java/sample/SecurityConfig.java
Outdated
Show resolved
Hide resolved
|
Really appreciate your detail review, I'll resolve the issues you point out and force push two commits :
|
jzheaux
added
in: saml2
|
@GitHanter are you able to make the requested changes? I'm happy to help make them if you are busy. |
|
@jzheaux Sorry for the delay. I was on my Spring Festival vacation last week, I'll do it this weekend CST. |
jzheaux
requested changes
Feb 23, 2021
There was a problem hiding this comment.
Thanks, @GitHanter! I've left just a bit more feedback inline.
...t/java/org/springframework/security/saml2/provider/service/web/Saml2MetadataFilterTests.java
Show resolved
Hide resolved
...c/main/java/org/springframework/security/saml2/provider/service/web/Saml2MetadataFilter.java
Show resolved
Hide resolved
|
@GitHanter, thanks again for the PR! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setMetadataFilename method to Saml2MetadataFilter
Populated shared objects RelyingPartyRegistrationRepository and DefaultRelyingPartyRegistrationResolver in Saml2LoginConfigurer class
Closes gh-9317