Allow ACL to be owned by GrantedAuthoritySid #9454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Closing as per comment |
jgrandja
added
in: acl
jgrandja
added
type: enhancement
jgrandja
requested changes
Mar 8, 2021
|
|
||
| AclAuthorizationStrategyImpl strategy; | ||
|
|
||
| @Before | ||
| public void setup() { |
There was a problem hiding this comment.
Please revert this change and preserve the @Before method and create a withUserRoles() static helper method instead.
There was a problem hiding this comment.
switching back to @Before method I realized that helper method is not needed
|
Thanks for the PR @bberto. This is now in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow ACL to be owned by GrantedAuthoritySid
Closes gh-9425