Skip to content

Throw Saml2AuthenticationException in Saml2AuthenticationTokenConverter on deflation or decoding error #9468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Throw Saml2AuthenticationException in Saml2AuthenticationTokenConverter on deflation or decoding error #9468

wants to merge 2 commits into from

Conversation

GitHanter
Copy link
Contributor

Saml2AuthenticationTokenConverter wrap SAMLResponse Base64 decode exception and inflate exception to Saml2AuthenticationException

Closes gh-9310

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 21, 2021
@GitHanter GitHanter force-pushed the gh-9310 branch 2 times, most recently from 9cd6c66 to 5e11bb7 Compare February 21, 2021 13:15
@jzheaux jzheaux added in: saml2 An issue in SAML2 modules type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 23, 2021
jzheaux
jzheaux requested changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @GitHanter! I've left some feedback inline.

@GitHanter
Saml2AuthenticationTokenConverter wrap SAMLResponse Base64 decode exc…
6ecff6b 
…eption and inflate exception to Saml2AuthenticationException

Update copyright year to 2021

Closes spring-projectsgh-9310
@GitHanter
spring-projectsgh-9310: Cleanup code
26aca85
@GitHanter GitHanter requested a review from jzheaux February 28, 2021 13:56
@jzheaux
Copy link
Contributor

jzheaux commented Mar 2, 2021

Thanks, @GitHanter, for another PR! This was merged to master via 6e41246 and f3fa8e8. Note that I moved some of your changes over to your polish commit so that the first commit only contains changes necessary to address #9310.

@jzheaux jzheaux closed this Mar 2, 2021
@jzheaux jzheaux added this to the 5.5.0-M3 milestone Mar 2, 2021
@eleftherias eleftherias changed the title Saml2AuthenticationTokenConverter gh-9310 Throw Saml2AuthenticationException in Saml2AuthenticationTokenConverter on deflation or decoding error Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux Awaiting requested review from jzheaux

Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Milestone
5.5.0-M3
3 participants
@GitHanter @jzheaux @spring-projects-issues