Update ComparableVersion to version from Maven 3.6.3 #9521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
candrews
force-pushed
the
ComparableVersion-from-maven-3.6.3
branch
from
4f7e691 to
519c551
Compare
rwinch
added
in: core
|
Thanks for the PR @candrews I've merged this into master as an enhancement. We only use this internally for validating Spring version compatibility, so the possible inputs is fairly limited and unlikely to find the NPE or need the enhancement. If we actually get a reproducible bug, we can consider backporting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ComparableVersion to be a copy of the class in Maven 3.6.3.
Among other improvements, this includes two problems of potential interest:
I discovered that this class was out of date when I ran a static analysis tool which identified the NPE issue.