Skip to content

Update javadoc for AesBytesEncryptor constructors #9536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

prashanttholia
Copy link
Contributor

Update AesBytesEncryptor constructors' javadoc to:

  1. mention default IV length and encryption mode,

  2. provide links to appropriate constructors that allow users to specify custom IV and encryption mode.

Related to gh-3879 and gh-9361

@pivotal-issuemaster
Copy link

@prashanttholia Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@prashanttholia Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 2, 2021
@prashanttholia prashanttholia changed the title Update javadoc for AesBytesEncrytor constructors Update javadoc for AesBytesEncryptor constructors Apr 2, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Apr 5, 2021

Thanks, @prashanttholia! In preparation for merging, will you please squash your commits?

Update AesBytesEncryptor constructors' javadoc to:
1. mention default IV length and encryption mode,
2. provide links to appropriate constructors that allow users to
specify custom IV and encryption mode.

Related to spring-projectsgh-3879 and spring-projectsgh-9361
@prashanttholia
Copy link
Contributor Author

@jzheaux, done!

@jzheaux jzheaux self-assigned this Apr 5, 2021
@jzheaux jzheaux added in: crypto An issue in spring-security-crypto type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 5, 2021
@jzheaux jzheaux merged commit 3c33535 into spring-projects:master Apr 5, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Apr 5, 2021

Thanks, @prashanttholia! This is now merged into master.

@jzheaux jzheaux added this to the 5.5.0-RC1 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: crypto An issue in spring-security-crypto type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants