-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add RequestedUrlRedirectInvalidSessionStrategy implemention of InvalidSessionStrategy #9632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rwinch
merged 5 commits into
spring-projects:main
from
candrews:RequestUrlInvalidSessionStrategy
May 26, 2021
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0b6edd8
Add RequestedUrlRedirectInvalidSessionStrategy implemention of Invali…
candrews 970d2d9
Eliminate use of Optional
candrews 0fdc931
Use ServletUriComponentsBuilder instead of UrlPathHelper
candrews 60bad85
Add guard around debug logging involving string concatenation
candrews 3ad57b2
Add test for RequestedUrlRedirectInvalidSessionStrategy
candrews File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
71 changes: 71 additions & 0 deletions
71
.../org/springframework/security/web/session/RequestedUrlRedirectInvalidSessionStrategy.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/* | ||
* Copyright 2002-2016 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.security.web.session; | ||
|
||
import java.io.IOException; | ||
import java.util.Optional; | ||
|
||
import javax.servlet.http.HttpServletRequest; | ||
import javax.servlet.http.HttpServletResponse; | ||
|
||
import org.apache.commons.logging.Log; | ||
import org.apache.commons.logging.LogFactory; | ||
|
||
import org.springframework.security.web.DefaultRedirectStrategy; | ||
import org.springframework.security.web.RedirectStrategy; | ||
import org.springframework.web.util.UrlPathHelper; | ||
|
||
/** | ||
* Performs a redirect to the original request URL when an invalid requested session is | ||
* detected by the {@code SessionManagementFilter}. | ||
* | ||
* @author Craig Andrews | ||
*/ | ||
public final class RequestedUrlRedirectInvalidSessionStrategy implements InvalidSessionStrategy { | ||
|
||
private final Log logger = LogFactory.getLog(getClass()); | ||
|
||
private final RedirectStrategy redirectStrategy = new DefaultRedirectStrategy(); | ||
|
||
private boolean createNewSession = true; | ||
|
||
private final UrlPathHelper urlPathHelper = new UrlPathHelper(); | ||
|
||
@Override | ||
public void onInvalidSessionDetected(HttpServletRequest request, HttpServletResponse response) throws IOException { | ||
String destinationUrl = this.urlPathHelper.getOriginatingRequestUri(request) | ||
+ Optional.ofNullable(this.urlPathHelper.getOriginatingQueryString(request)).filter((s) -> !s.isEmpty()) | ||
candrews marked this conversation as resolved.
Show resolved
Hide resolved
|
||
.map((s) -> "?" + s).orElse(""); | ||
this.logger.debug("Starting new session (if required) and redirecting to '" + destinationUrl + "'"); | ||
candrews marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if (this.createNewSession) { | ||
request.getSession(); | ||
} | ||
this.redirectStrategy.sendRedirect(request, response, destinationUrl); | ||
} | ||
|
||
/** | ||
* Determines whether a new session should be created before redirecting (to avoid | ||
* possible looping issues where the same session ID is sent with the redirected | ||
* request). Alternatively, ensure that the configured URL does not pass through the | ||
* {@code SessionManagementFilter}. | ||
* @param createNewSession defaults to {@code true}. | ||
*/ | ||
public void setCreateNewSession(boolean createNewSession) { | ||
this.createNewSession = createNewSession; | ||
} | ||
|
||
} | ||
candrews marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.