Skip to content

Adjust createNewSessionIfAllowed to prevent NPE #9813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2021
Merged

Adjust createNewSessionIfAllowed to prevent NPE #9813

merged 1 commit into from
May 26, 2021

Conversation

marcusdacoregio
Copy link
Contributor

Ensure that HttpSessionSecurityContextRepository#isTransientAuthentication reuses the same authentication object from SaveToSessionResponseWrapper#saveContext

Closes gh-8947

@marcusdacoregio marcusdacoregio added status: duplicate A duplicate of another issue in: web An issue in web modules (web, webmvc) type: bug A general bug labels May 26, 2021
@marcusdacoregio marcusdacoregio requested a review from jzheaux May 26, 2021 12:08
@marcusdacoregio marcusdacoregio self-assigned this May 26, 2021
@marcusdacoregio marcusdacoregio mentioned this pull request May 26, 2021
Closed
jzheaux
jzheaux requested changes May 26, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marcusdacoregio! I've left some feedback inline.

@marcusdacoregio marcusdacoregio added this to the 5.6.0-M1 milestone May 26, 2021
@marcusdacoregio
Adjust createNewSessionIfAllowed to prevent NPE
5c85565 
Ensure that isTransientAuthentication reuses the same authentication object from saveContext

Closes spring-projectsgh-8947
@marcusdacoregio
Copy link
Contributor Author

Thanks for your time, I've worked on your suggestion @jzheaux.

@marcusdacoregio marcusdacoregio requested a review from jzheaux May 26, 2021 15:28
@jzheaux jzheaux merged commit 2a7998d into spring-projects:main May 26, 2021
@marcusdacoregio marcusdacoregio deleted the gh-8947 branch May 26, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@marcusdacoregio marcusdacoregio

Labels
in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Milestone
5.6.0-M1
Development

Successfully merging this pull request may close these issues.

NPE in HttpSessionSecurityContextRepository.isTransientAuthentication
2 participants
@marcusdacoregio @jzheaux