Added support for the CAS gateway feature. #9881
Conversation
|
@yvangg Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@yvangg Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
|
Do we have any news about this? Why is not being merged? |
rwinch
added
in: cas
|
Hi, @marcusdacoregio I understand that you have removed that in Spring Security 6.0, but, Why don't you accept this request on the 5.5.x branch? Our applications are using spring-security 5.5.x and we do not have in mind update to 6.0 soon. It will be helpfull have support for the CAS gateway feature. |
marcusdacoregio
removed
the
status: waiting-for-triage
|
Hi @yvangg. Unfortunately, we can't add new features to older branches, like We are gonna start planning features for the |
| HttpServletResponse response = (HttpServletResponse) res; | ||
|
|
||
| if (requestMatcher.matches(request)) { | ||
| throw new TriggerCasGatewayException("Try a CAS gateway authentication"); |
There was a problem hiding this comment.
This is not a failed authentication attempt, so a subclass of AuthenticationException should not be thrown here
| @@ -25,6 +25,7 @@ | |||
|
|
|||
| import org.springframework.beans.factory.InitializingBean; | |||
| import org.springframework.security.cas.ServiceProperties; | |||
| import org.springframework.security.cas.authentication.TriggerCasGatewayException; | |||
There was a problem hiding this comment.
Among other tangles, this introduces a tangle between between org.springframework.security.cas.authentication and org.springframework.security.cas.web. In general, authentication package should not rely on web.
|
I'll close this since we do not have more minor releases planned for 5.x and the CAS support has been removed in Spring Security 6. See #10441 |
marcusdacoregio
added
the
status: declined
|
But there is also a ticket to re-add CAS... So why do not link to #11674. This is an important feature and if I remember correctly original issue about it has probably +10 years. |
|
Ok, I'll subscribe #11674. |
|
#11674 is closed and CAS is re-added. Please, consider opening this issue again. |
|
Hi @marcusdacoregio, I am willing to work on this. But probably I will need to test again the changes in the current 6.1.x branch, In addition, I did not receive any answer from @rwinch about some of my comments. I will checkout the main branch and I will test it again, if everything works as I expect I will do a new PR. |
|
Hi, are the are news regarding this issue? This would be a quite helpful feature to have and it seems like there is interest in implementing it. Perhaps re-opening the ticket should be considered. |
|
Hi @SandwichCZ, we haven't received any news from @yvangg yet and there is none from the team either. |
This is the CAS gateway feature.
This is a implementation based on the following discussion (PR): #40
I did some modifications in order to perform the CAS gateway redirection only if the CAS cookie is present on the client application request. Of course this will not fit in all situations (where CAS domain is different from client applications won't work), but for many of situations this is a pretty good approach.
Regards.