adding ReactiveFindByIndexNameSessionRepository #1205
Conversation
…ssion into add-reactiveFindByIndexNameSessionRepository
|
@vpavic, Do i have chance thtat It'll be merged ? |
|
Thanks for the PR @ayudovin - we'll give this a closer look when we start working on 2.2. |
There was a problem hiding this comment.
Thanks for the PR @ayudovin, I've left some comments as it isn't obvious how the implementation works. You might also want to take a look at RedisOperationsSessionRepository for inspiration (see class javadoc).
I also think that in light of #1408 and further developments around it we might want to keep the existing ReactiveRedisOperationsSessionRepository and if we end up supporting ReactiveFindByIndexNameSessionRepository we might do it in a separate implementation as support for indexing will likely require more complexity.
| @@ -192,6 +198,24 @@ private String getSessionKey(String sessionId) { | |||
| return this.namespace + "sessions:" + sessionId; | |||
| } | |||
|
|
|||
| private String getPrincipalKey(String principalName) { | |||
There was a problem hiding this comment.
If I'm not mistaken, the index key constructed here is only used for reading - what does actually write the index?
| } | ||
| String principalKey = getPrincipalKey(indexValue); | ||
| return this.sessionRedisOperations.opsForSet() | ||
| .scan(principalKey) |
There was a problem hiding this comment.
I'm afraid this isn't optimal, as you would be scanning for a match each time, rather having an index that's updated on write and have reads simple.
vpavic
added
the
status: waiting-for-feedback
|
Closing due to lack of feedback. Please comment back if you can provide more details and we can re-open the issue. |
vpavic
removed
in: redis
status: waiting-for-feedback
vpavic
added
status: declined
A reactive equivalent to FindByIndexNameSessionRepository. This enhancement