Suggested changes for compatibility with hazelcast:4.0.1 and spring-boot:2.3.0 on the branch 'v2.3.x'

[adeniyiodunlami]

Suggested changes for compatibility with hazelcast:4.0.1 and spring-boot:2.3.0.
#1644
gh-1584

[eleftherias]

Thanks for the PR @adeniyiodunlami!

As discussed in gh-1584, we cannot upgrade to Hazelcast 4.

We would accept a PR that offers support for Hazelcast 4, while still providing full support for Hazelcast 3.
This would be similar to the changes Spring Boot made for spring-projects/spring-boot#21169.

[eleftherias]

After some discussion, we have decided to take a different approach than the Spring Boot team.
Instead of using reflection, we will create a new class, similar to HazelcastIndexedSessionRepository that is compatible with Hazelcast 4.

We will likely leverage some of the work that was done in this PR and will continue to keep you updated as we make progress.

[vpavic]

we will create a new class, similar to HazelcastIndexedSessionRepository that is compatible with Hazelcast 4.

I'd suggest against this approach, as it will inevitably result in:

• duplicated code
• SessionRepository component that's bound to be deprecated once Hazelcast 4 is baseline
• more difficult configuration

IMO a better way to tackle this would be to extract a strategy that encapsulates the use of Hazelcast API's that introduced binary incompatible changes between Hazelcast 3.x and 4.x - HazelcastIndexedSessionRepository would internally implement this strategy to keep the existing (Hazelcast 3.x compabile) behaviour while additional implementation would be provided to support Hazelcast 4.x.

Once Hazelcast 4.x is the baseline (likely Spring Session 3.0) those implementations simply switch places.

[pivotal-issuemaster]

@adeniyiodunlami Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-issuemaster]

@adeniyiodunlami Thank you for signing the Contributor License Agreement!

[eleftherias]

As discussed in the associated issue gh-1644, changes to support Hazelcast 4 were introduced via 2b6489c.
For that reason I'm closing this issue as a duplicate.