Add support for configuring JDBC session cleanup cron #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2017
vpavic
force-pushed
the
improve-jdbc-config
branch
from
14e7729 to
162233b
Compare
|
Thanks @vpavic! Can you fix the conflicts and then merge this? |
|
No problem, actually I was just about to address this. |
vpavic
force-pushed
the
improve-jdbc-config
branch
from
162233b to
74595ea
Compare
vpavic
force-pushed
the
improve-jdbc-config
branch
from
74595ea to
97698fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we currently do have some configuration support for customizing expired session cleanup cron, this binds directly to specific property and is not exposed using standard configuration facilities (
JdbcHttpSessionConfiguration/@EnableJdbcHttpSession). This makes it difficult to expose as application property in Spring Boot.Customization of cron expression is desirable in scenarios with multiple active nodes, where cleanup should ideally run at different schedule on each node in order to reduce the possibility of deadlock occurrence.
Additionally, since current support is property based, it includes registration of
PropertySourcesPlaceholderConfigurerbean inJdbcHttpSessionConfigurationwhich causes conflicts for some users (see #775).