Skip to content

RepositoryStateMachineModelFactory failed to create ChoiceData #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danieldingzju opened this issue Mar 19, 2021 · 1 comment
Closed

RepositoryStateMachineModelFactory failed to create ChoiceData #934

danieldingzju opened this issue Mar 19, 2021 · 1 comment
Labels
branch/2.2.x Issue for a branch branch/2.3.x Issue for a branch branch/2.4.x Issue for a branch branch/3.0.x Issue for a branch for/backport For backporting type/bug Is a bug report
Milestone
3.1.0-RC1

Comments

@danieldingzju
Copy link
Contributor

My project use RepositoryStateMachineModelFactory to extend StateMachineModel Persistent, just simple override the resolveAction and resolveGuard methods.
Lately I encounter that the following transitions start from the CHOICE node will not execute the actions, then I study the source code and found that RepositoryStateMachineModelFactory's build logic with CHOICE node ignore the transitions' action while constructing the ChoiceData.
@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Mar 19, 2021
@danieldingzju danieldingzju mentioned this issue Mar 19, 2021
Merged
@jvalkeal jvalkeal added type/bug Is a bug report and removed status/need-triage Team needs to triage and take a first look labels Jun 26, 2021
@jvalkeal
Copy link
Contributor

Thanks, looking the PR, I think it has been an oversight indeed.

@jvalkeal jvalkeal added branch/2.2.x Issue for a branch branch/2.3.x Issue for a branch branch/2.4.x Issue for a branch branch/3.0.x Issue for a branch for/backport For backporting labels Jun 26, 2021
This was referenced Jun 26, 2021
Closed
Closed
Closed
Closed
@jvalkeal jvalkeal added this to the 3.1.0-RC1 milestone Jun 26, 2021
jvalkeal pushed a commit that referenced this issue Jun 27, 2021
@danieldingzju @jvalkeal
Fix repository factory choice junction action construction
caaf5ec 
- add actions to CHOICE & JUNCTION node
- Backport #934
- Fixes #977
jvalkeal pushed a commit that referenced this issue Jun 27, 2021
@danieldingzju @jvalkeal
Fix repository factory choice junction action construction
c42dc00 
- add actions to CHOICE & JUNCTION node
- Backport #934
- Fixes #976
jvalkeal pushed a commit that referenced this issue Jun 27, 2021
@danieldingzju @jvalkeal
Fix repository factory choice junction action construction
f3ec13b 
- add actions to CHOICE & JUNCTION node
- Backport #934
- Fixes #974
jvalkeal pushed a commit that referenced this issue Jun 27, 2021
@danieldingzju @jvalkeal
Fix repository factory choice junction action construction
6c015d5 
- add actions to CHOICE & JUNCTION node
- Backport #934
- Fixes #975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch/2.2.x Issue for a branch branch/2.3.x Issue for a branch branch/2.4.x Issue for a branch branch/3.0.x Issue for a branch for/backport For backporting type/bug Is a bug report
Projects
None yet
Milestone
3.1.0-RC1
Development

No branches or pull requests
2 participants
@jvalkeal @danieldingzju