Skip to content

Github Token Authentication #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
radhakrishna67 opened this issue Oct 10, 2023 · 1 comment
Closed

Github Token Authentication #821

radhakrishna67 opened this issue Oct 10, 2023 · 1 comment
Labels
type: enhancement A general enhancement
Milestone
3.2.0-M1

Comments

@radhakrishna67
Copy link

Hi team,
we are allowed to use only GitHub token to login into HashiCorp Vault. Spring Vault is currently not supporting GitHub token authentication method.
Could you please consider this as an enhancement ?

Thanks,
Radhakrishna.
@radhakrishna67 radhakrishna67 changed the title Spring Vault Github Authentication method request Spring Vault Github Token Authentication method request Oct 10, 2023
@mp911de
Copy link
Member

mp911de commented Oct 10, 2023

Right now, you're the first one who asked. Spring Vault comes with an extensible model so for the time being, feel free to implement your own ClientAuthentication based on GitHub tokens.

@mp911de mp911de added the type: enhancement A general enhancement label Oct 16, 2023
nbaars added a commit to nbaars/spring-vault that referenced this issue Jan 18, 2024
@nbaars
Add GitHub authentication.
f2b24d8 
Related to: spring-projectsgh-821
nbaars added a commit to nbaars/spring-vault that referenced this issue Jan 18, 2024
@nbaars
Add GitHub authentication.
332c1e4 
Related to: spring-projectsgh-821

(cherry picked from commit f2b24d8)
nbaars added a commit to nbaars/spring-vault that referenced this issue Jan 18, 2024
@nbaars
Add GitHub authentication.
0270582 
Related to: spring-projectsgh-821

(cherry picked from commit f2b24d8)
@nbaars nbaars mentioned this issue Jan 18, 2024
Closed
@mp911de mp911de closed this as completed in fdcab61 Jun 6, 2024
mp911de added a commit that referenced this issue Jun 6, 2024
@mp911de
Polishing.
114f944 
Refactor AuthenticationSteps creation into static factory method.

Extend tests, add documentation.

See gh-821
Original pull request: gh-853
@mp911de mp911de added this to the 3.2.0 milestone Jun 6, 2024
@mp911de mp911de changed the title Spring Vault Github Token Authentication method request Github Token Authentication Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.2.0-M1
Development

No branches or pull requests
2 participants
@mp911de @radhakrishna67