Skip to content

Apply read timeout to http-components request factory. Fixes #861 #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Entea
Copy link
Contributor

@Entea Entea commented May 15, 2024

Fixes read timeout issue - spring webflux application could hang indefinitely on read if vault is not responding :)

@pivotal-cla
Copy link

@Entea Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@Entea Thank you for signing the Contributor License Agreement!

@mp911de mp911de linked an issue May 16, 2024 that may be closed by this pull request
mp911de pushed a commit that referenced this pull request May 16, 2024
mp911de added a commit that referenced this pull request May 16, 2024
Configure ResponseTimeout for a Request, move off deprecated API by always configuring a PoolingHttpClientConnectionManager.

See gh-861
Original pull request: gh-866
mp911de pushed a commit that referenced this pull request May 16, 2024
mp911de added a commit that referenced this pull request May 16, 2024
Configure ResponseTimeout for a Request, move off deprecated API by always configuring a PoolingHttpClientConnectionManager.

See gh-861
Original pull request: gh-866
@mp911de
Copy link
Member

mp911de commented May 16, 2024

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this May 16, 2024
@mp911de mp911de added the type: bug A general bug label May 16, 2024
@mp911de mp911de added this to the 3.1.2 milestone May 16, 2024
natedanner pushed a commit to natedanner/spring-projects__spring-vault that referenced this pull request May 20, 2024
natedanner pushed a commit to natedanner/spring-projects__spring-vault that referenced this pull request May 20, 2024
Configure ResponseTimeout for a Request, move off deprecated API by always configuring a PoolingHttpClientConnectionManager.

See spring-projectsgh-861
Original pull request: spring-projectsgh-866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read-Timeout not applied with Apache Http Components and no-SSL
3 participants