AxiomSoapFaultDetailElementIterator does not consider whitespace nodes [SWS-142]

[gregturn]

Kai Hudalla opened SWS-142 and commented

The org.springframework.ws.soap.axiom.AxiomSoapFaultDetail$AxiomFaultDetailElementIterator throws a ClassCastException if the Fault Detail element contains whitespace nodes, e.g. line breaks (\n). This seems to be due to the fact that the next() method casts everything to OMElement and does not consider OMTextImpl nodes (which represent whitespace).

---

Affects: 1.0 RC2

Attachments:

• AxiomSoapFaultDetail.java (3.00 kB)
• AxiomSoapFaultDetailTest.java (3.67 kB)

Referenced from: commits a9b118b, 905702d

[gregturn]

Kai Hudalla commented

JUnit test case for demonstrating the problem

[gregturn]

Kai Hudalla commented

I think the AxiomSoapFaultDetail.getDetailEntries() method should simply return getAxiomFaultDetail().getChildElements() instead of instantiating an AxiomSoapFaultDetailElementIterator for getAxiomFaultDetail().getAllDetailEntries() (which seems to return all child nodes, not only the child elements)

[gregturn]

Kai Hudalla commented

The getDetailEntries() method has been changed in order to fix the problem. With this fix the test case succeeds as well. Maybe you can integrate it into the next release.

[gregturn]

Arjen Poutsma commented

Fixed, thanks for the patch and the test!

[gregturn]

Arjen Poutsma commented

Closing issues for 1.0.0