WebServiceTemplte needs two more methods in order to easy enable ws security client support [SWS-148]

[gregturn]

Giovanni Cuccu opened SWS-148 and commented

see http://forum.springframework.org/showthread.php?t=40393

---

Affects: 1.0 M3, 1.0 RC1, 1.0 RC2

Attachments:

• security.zip (11.61 kB)
• WebServiceOperations.java (18.23 kB)
• WebServiceTemplate.java (29.68 kB)

Issue Links:

• Add Interceptor functionality to WebServiceTemplate [SWS-194] #346 Add Interceptor functionality to WebServiceTemplate
  ("depends on")
• Client-side WS-Security support [SWS-143] #281 Client-side WS-Security support

2 votes, 1 watchers

[gregturn]

Giovanni Cuccu commented

Here is a new version of WebServiceTemplate implementing the two methods

[gregturn]

Giovanni Cuccu commented

the interface with the two added methods

[gregturn]

Jeff Peterson commented

It seems that there may be a better general-purpose pattern for handing these situations. The AbstractEndpointMapping class uses a series of EndpointInterceptors to elegantly solve the same problem of pre/post processing messages. Perhaps a refactoring away from this concept of a 'callback' and towards the concept of a series of 'interceptors' would provide a better long-term solution.

[gregturn]

Giovanni Cuccu commented

Jeff, I agree with you, the concept of interceptor looks a better long solution to me also. But now we have the callback mechanism, and I think that only after a discussion with Arjen we can choose what is the best strategy for the future

[gregturn]

Arjen Poutsma commented

Having interceptors on the client-side, similar to the server-side, is planned for 1.1.

[gregturn]

Giovanni Cuccu commented

Arjen, do you have some idea of the resulting classes? i.e. do you plan a new class with interceptors or to add interceptors to webservicetemplate? if you plan to modifiy webserviceTemplate how interceptors relate to callbacks? I'm very interested in this feature and I'd like to contribute one I know how to proceed.

[gregturn]

Jeff Peterson commented

Giovanni,

Please check out #317. Hopefully it does what you are looking for.

• Jeff

[gregturn]

Giovanni Cuccu commented

This is the implementation of ws security on the client side. in the zip there is only the security module as of Arjen's request (http://forum.springframework.org/showthread.php?t=43632) the client code is attached to #346.
Here is what I've done.
I refactored the abstract security interceptor into one base class and now there are two descending classes:
AbstractClientWsSecurityInterceptor.java for client support
AbstractEndpointWsSecurityInterceptor.java for server support
the xwss implementation is refactored in a similar way
BaseXwsSecurityInterceptor.java implements the xwss callbacks and
ClientXwsSecurityInterceptor.java use it for client support while
XwsSecurityInterceptor.java use it for server support.
In this way the callback handlers are the same
I think that XwsSecurityInterceptor sould be named EndpointXwsSecurityInterceptor but i didn't want to break any compatibility.
I hope this is what you were looking for.

[gregturn]

Arjen Poutsma commented

See #346

[gregturn]

Arjen Poutsma commented

Closing 1.5 M2 issues.