Namespace declarations may be removed from the wsdl when transformWsdlLocations = true [SWS-203]

[gregturn]

Erik-Berndt Scheper opened SWS-203 and commented

See http://forum.springframework.org/showthread.php?t=44599

When a SimpleWsdl11Definition is used in combination with transformWsdlLocations=true, namespace declarations are removed which leads to an invalid wsdl.

Resetting transfromWsdlLocations to false resolves the issue (with the penalty that the wsdl locations are no longer transformed).

---

Affects: 1.0.1

Attachments:

• sws-203.patch (1.47 kB)
• sws-203-tests.patch (10.27 kB)
• WsdlDefinitionHandlerAdapterTestExtension.zip (3.84 kB)

Referenced from: commits a7fb4bb

[gregturn]

Arjen Poutsma commented

Could you try to use Xalan 2.7 and Xerces 2.8.1? That might solve this issue...

[gregturn]

Erik-Berndt Scheper commented

That's why I tried to recreate the problem with the echo sample.
AFAIK the echo sample already uses xalan 2.7 and xerxes 2.8.1.
At least, if I build it then the echo.war in samples/echo/target already contains these jars.
Just to be sure, I copied xalan-2.7.0.jar and xercesImpl-2.8.1 to j2se-1.5.0_12/jre/lib/endorsed and re-ran mvn jetty:run but with the same results.

[gregturn]

Erik-Berndt Scheper commented

I've created two extra testcases which can be added to the WsdlDefinitionHandlerAdapterTest. These demonstrate the problem.

The first testcase (testHandleSimpleWsdl11DefinitionWithoutTransformLocations) creates a WsdlDefinitionHandlerAdapter (using a SimpleWsdl11Definition) with transformlocations = false. The expected result is the input of the SimpleWsdlDefinition.

The second testcase (testHandleSimpleWsdl11DefinitionWithTransformLocations) creates the WsdlDefinitionHandlerAdapter (using a SimpleWsdl11Definition) with transformlocations = true. The expected result is a different (but valid) wsdl.
However, I get the following error upon validation by wsdl4j:

 
javax.wsdl.WSDLException: WSDLException (at /wsdl:definitions/wsdl:message[1]/wsdl:part): faultCode=UNBOUND_PREFIX: Unable to determine namespace of 'schema:echoResponse'.
	at com.ibm.wsdl.util.xml.DOMUtils.getQName(Unknown Source)
	at com.ibm.wsdl.util.xml.DOMUtils.getQualifiedAttributeValue(Unknown Source)
	at com.ibm.wsdl.xml.WSDLReaderImpl.getQualifiedAttributeValue(Unknown Source)
	at com.ibm.wsdl.xml.WSDLReaderImpl.parsePart(Unknown Source)
	at com.ibm.wsdl.xml.WSDLReaderImpl.parseMessage(Unknown Source)
	at com.ibm.wsdl.xml.WSDLReaderImpl.parseDefinitions(Unknown Source)
	at com.ibm.wsdl.xml.WSDLReaderImpl.readWSDL(Unknown Source)
	at com.ibm.wsdl.xml.WSDLReaderImpl.readWSDL(Unknown Source)
	at com.ibm.wsdl.xml.WSDLReaderImpl.readWSDL(Unknown Source)
	at com.ibm.wsdl.xml.WSDLReaderImpl.readWSDL(Unknown Source)
	at org.springframework.ws.transport.http.WsdlDefinitionHandlerAdapterTest.testHandleSimpleWsdl11DefinitionWithTransformLocations(WsdlDefinitionHandlerAdapterTest.java:138)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at junit.framework.TestCase.runTest(TestCase.java:164)
	at junit.framework.TestCase.runBare(TestCase.java:130)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:120)
	at junit.framework.TestSuite.runTest(TestSuite.java:230)
	at junit.framework.TestSuite.run(TestSuite.java:225)
	at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)

[gregturn]

Erik-Berndt Scheper commented

BTW The System.out.println in both test methods can of course be removed from these tests, should you decide to include them.

[gregturn]

Erik-Berndt Scheper commented

I just found that if I remove xalan-2.7.0.jar from the classpath that the testcase no longer fails (and my system out does indeed show the namespace prefixes that were removed previously.

[gregturn]

Erik-Berndt Scheper commented

Verified the above with various supported runtimes:

IBM JDK 1.4.2 SR5 (default installation): not supported (spring-ws FAQ)
IBM JDK 1.4.2 SR5 (with endorsed libraries xalan-2.7.0, xercesImpl-2.8.1 and xml-apis-1.3.04): namespace prefixes removed

SUN JDK 1.4.2_15 (default installation): not supported (spring-ws FAQ)
SUN JDK 1.4.2_15 (with endorsed libraries xalan-2.7.0, xercesImpl-2.8.1 and xml-apis-1.3.04): namespace prefixes removed

SUN JDK 1.5.0_12 (default installation): works OK
SUN JDK 1.5.0_12 with xalan-2.7 in the classpath: namespace prefixes removed

SUN JDK 1.6.0_02 (default installation): works OK
SUN JDK 1.6.0_02 with xalan-2.7 in the classpath: not supported, nevertheless namespace prefixes are removed

[gregturn]

Arjen Poutsma commented

Thanks for the detailed report. It will surely help resolving this issue, if possible.

[gregturn]

Erik-Berndt Scheper commented

Both testcases run successfully in my environment with the attached patch for SimpleWsdl11Definition.java

[gregturn]

Erik-Berndt Scheper commented

(Verified on all the above runtimes)

[gregturn]

Erik-Berndt Scheper commented

And a separate patch file for the new tests.

Note that I get one failing test if I run mvn package inside the core directory without having applied the patch for the SimpleWsdl11Definition.
All tests succeed if I run mvn package after both patches have been applied.
Apparently mvn package always includes xalan in the path, since my default java version is 1.5.0_12.

[gregturn]

Arjen Poutsma commented

Fixed. Thanks for the patch!

[gregturn]

Arjen Poutsma commented

Closing 1.0.2 issues.