Don't abuse Assert.isTrue [SWS-204]

[gregturn]

Ray Krueger opened SWS-204 and commented

Use Assert.isInstanceOf rather than Assert.isTrue

This...
Assert.isTrue(messageContext.getResponse() instanceof SoapMessage, "SimpleSoapExceptionResolver requires a SoapMessage");

Should be this...
Assert.isInstanceOf(SoapMessage.class, messageContext.getResponse(), "SimpleSoapExceptionResolver requires a SoapMessage");

Just an observation :)

---

Affects: 1.0, 1.0.1

Referenced from: commits 40bd80f

[gregturn]

Arjen Poutsma commented

Thanks, I didn't even know that Assert.isInstanceOf existed!

[gregturn]

Arjen Poutsma commented

Closing 1.0.2 issues.