Spring Web Services does not seem to work with Castor 1.2 [SWS-287]

[gregturn]

Jim Cummings opened SWS-287 and commented

As brought up in the forum at http://forum.springframework.org/showthread.php?t=49583, it looks like as of Castor 1.2, castor has changed the way their XMLClassDescriptorResolver behaves that is incompatible with the way CastorMarshaller.java is using it.

While loading the spring config you'll get the following exception:

Caused by: java.lang.NullPointerException
at org.exolab.castor.xml.util.XMLClassDescriptorResolverImpl.setMappingLoader(XMLClassDescriptorResolverImpl.java:143)
at org.springframework.oxm.castor.CastorMarshaller.createClassDescriptorResolver(CastorMarshaller.java:325)
...

I think spring-ws's CastorMarshaller may need to change to use Castor's XMLContext instead of the resolver directly and when creating castor's Marshaller/Unmarshaller. I was able to do this with local changes and it works fine, but that would probably break pre-1.2 Castor so the real framework change would likely involve a bit more.

---

Affects: 1.0.3

Attachments:

• castor1.2_patch.txt (5.96 kB)

Issue Links:

• Add namespaceMappings property to CastorMarshaller [SWS-309] #465 Add namespaceMappings property to CastorMarshaller
  ("is depended on by")

Referenced from: commits f61e401

7 votes, 7 watchers

[gregturn]

Arjen Poutsma commented

Could you please supply the local changes you made as a patch? Thanks.

[gregturn]

Jim Cummings commented

Arjen - here are the local changes I had made in case it is useful. This passes the spring-ws tests and worked for my problem at hand as well.

The supports() method clearly isn't as smart now. I'm hoping the various class loading scenarios would work with this, but I'm not confident since going with XMLContext seems to limit your control over the class loaders a bit.

Also, this does break pre-castor 1.2 as well.

[gregturn]

Erik-Berndt Scheper commented

I've verified that the supplied patch works fine for me, too.

[gregturn]

jang commented

I had the same problem and this patch works good.
Will it be implemented in Spring web services 1.5 ?????

[gregturn]

Erik-Berndt Scheper commented

See #465 for another improvement on the CastorMarshaller class.

[gregturn]

Arjen Poutsma commented

After doing some research, I have come to the conclusion that it is impossible to support both Castor 1.1.1- and 1.1.2+ with the same marshaller. I tried various reflection tricks, but it seems impossible to differentiate between the different Castor versions. The fact that XMLContext was introduced in 1.1.2 doesn't really help here, since that means it's not a 1.1 vs. 1.2 differentiator.

So, I think the way forward is to support Castor 1.2+ only. It's really a shame that Castor broke the existing behavior with a minor version upgrade, thus forcing us into this.

[gregturn]

Arjen Poutsma commented

Resolved, though this means that the CastorMarshaller only works with 1.2+.

[gregturn]

Werner Guttmann commented

Arjen, being a committer of Castor, I'd like to know what the issue is ?

[gregturn]

Arjen Poutsma commented

Closing issues for 1.5.1

[gregturn]

Vyas Sanzgiri commented

I am still experiencing the same issue with 1.5.2 and castor 1.2. Is this fixed?