Prevent AxiomSoapElement from creating attributes with invalid names #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axiom 1.2.14 allows creation of attributes with a namespace URI and an empty prefix, but the behavior for attributes with such an invalid name is undefined. Axiom 1.2.15 will refuse to create such an attribute. This change modifies AxiomSoapElement#addAttribute so that it lets Axiom generate a prefix if necessary. All tests now pass successfully with Axiom 1.2.15-SNAPSHOT.
poutsma
pushed a commit
that referenced
this pull request
Jul 2, 2013
* axiom_attribute: Prevent invalid Axiom attributes
|
Merged. Thanks for the patch. Next time, please create a new branch for a pull request. Merging from master makes me feel weird :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axiom 1.2.14 allows creation of attributes with a namespace URI and an
empty prefix, but the behavior for attributes with such an invalid name
is undefined. Axiom 1.2.15 will refuse to create such an attribute. This
change modifies AxiomSoapElement#addAttribute so that it lets Axiom
generate a prefix if necessary. All tests now pass successfully with
Axiom 1.2.15-SNAPSHOT.