PR: Add initial contributing guide and release steps docs#79
Merged
ok97465 merged 2 commits intospyder-ide:masterfrom Sep 13, 2022
Merged
PR: Add initial contributing guide and release steps docs#79ok97465 merged 2 commits intospyder-ide:masterfrom
ok97465 merged 2 commits intospyder-ide:masterfrom
Conversation
ok97465
reviewed
Sep 10, 2022
Contributor
|
Hi @dalthviz ! Thank you very much. I don't have experience with the release, so I can't review Release.md in details, but LGTM. I just left minor comments. |
Co-authored-by: ok97465 <ok97465@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #78 some of the missing things to do a release are adding some docs: a contributing guide and some instructions to do a release.
@ok97465 could you give this a review and if it looks good for you approve it and merge it?
You should have write permissions over this repo, so I think you should me able to merge it but let me know if that is not possible :)
Part of #78