Layer to convert Tensor to SparseTensor dropping ignore values #1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingloong
requested review from
terrytangyuan,
skydoorkai,
QiJune and
brightcoder01
QiJune
reviewed
Mar 20, 2020
| Arguments: | ||
| ignore_value: Entries in inputs equal to this value will be | ||
| absent from the output `SparseTensor`. If `None`, default value of | ||
| inputs dtype will be used ('' for `str`, -1 for `int`). |
There was a problem hiding this comment.
-1 for int seems dangerous as this is application specific
There was a problem hiding this comment.
-1 for int is the default value and the layer will ignore it during transformation.
There was a problem hiding this comment.
-1 for
intseems dangerous as this is application specific
Use -1 as the default ignore_value for int type is also the implementation inside feature column. Please check the code snippet.
brightcoder01
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1844