dialect_kwargs are not supported for foreign key creation

[jrmalin]

Describe the use case

SqlAlchemy supports adding dialect kwargs for foreign keys, as does op.create_foreign_key(), but the renderer for ops.CreateForeignKeyOp does not pass through dialect_kwargs. An example of this is postgresql_not_valid.

Databases / Backends / Drivers targeted

postgres

Example Use

ALTER TABLE t1 ADD CONSTRAINT i FOREIGN KEY(c1) REFERENCES t2 (c2) NOT VALID;

Additional context

This was quite confusing, as it is documented as if it is handled, and it dialect_kwargs seem to be passed through for other constraints, just not for foreign keys. I have already begun working on the solution here.

Have a nice day!

[zzzeek]

SqlAlchemy supports adding dialect kwargs for foreign keys, as does op.create_foreign_key(), but the renderer for ops.CreateForeignKeyOp does not pass through dialect_kwargs.

the autogenerate renderer? I dont think that the PostgreSQL dialect reflects "not valid" right now so this would only matter if you are using a custom rewriter, is that the case here?

[jrmalin]

SqlAlchemy supports adding dialect kwargs for foreign keys, as does op.create_foreign_key(), but the renderer for ops.CreateForeignKeyOp does not pass through dialect_kwargs.

the autogenerate renderer? I dont think that the PostgreSQL dialect reflects "not valid" right now so this would only matter if you are using a custom rewriter, is that the case here?

Correct, I am using a custom rewriter with this!

[sqla-tester]

Justin Malin has proposed a fix for this issue in the main branch:

[Fixes #1671] Passthrough dialect_kwargs to ops.create_foreign_key() https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5985