Skip to content

fix: make dogpile.cache.memory preserve its init parameters #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0xDEC0DE wants to merge 1 commit into from
Closed

fix: make dogpile.cache.memory preserve its init parameters #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dogpile/cache/backends/memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class MemoryBackend(CacheBackend):
"""

def __init__(self, arguments):
self._cache = arguments.pop("cache_dict", {})
self._cache = arguments.get("cache_dict", {})

def get(self, key):
return self._cache.get(key, NO_VALUE)
Expand Down
6 changes: 5 additions & 1 deletion tests/cache/test_memory_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

class MemoryBackendTest(_GenericBackendTestSuite):
backend = "dogpile.cache.memory"
config_args = {"arguments": {"cache_dict": {}}}

def test_config_args_does_not_mutate(self):
assert "cache_dict" in self.config_args["arguments"]


class MemoryBackendSerializerTest(
Expand All @@ -12,5 +16,5 @@ class MemoryBackendSerializerTest(
pass


class MemoryPickleBackendTest(_GenericBackendTestSuite):
class MemoryPickleBackendTest(MemoryBackendTest):
backend = "dogpile.cache.memory_pickle"