Remove Legacy Layout #475
Closed
Remove Legacy Layout #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kyleve
commented
Dec 13, 2023
| view.ensureLayoutPass() | ||
| XCTAssertEqual(contextualMode, overrideMode) | ||
| } | ||
| // TODO: Decide what to do here. Can't test overrides w/ only one layout mode... |
There was a problem hiding this comment.
- Need to figure this out before merge
kyleve
commented
Dec 13, 2023
There was a problem hiding this comment.
Some tests depend on turning this on/off to count measurements, so I decided to leave it in. Figure we can always remove it in a later iteration.
|
Let's talk about the strategy for this in January.
|
|
Do you mind enumerating concrete concerns to removing legacy layout? Eg:
|
|
I'm closing this out as it sounds like we want to do the removal different than done here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a swing at deleting the
Legacylayout system, since it's no longer used, but is required to be implemented for newLayouttypes. To do this, I:Layoutprotocol.ContentStorageprotocol.legacyLayoutMode.Layoutdirectly).Open Questions
I've left comments on things I'm not 100% sure what to do with, but the biggest open question is do we leave the
LayoutModeenum around at all. I've opted to leave it in, because we can continue to leverage this to test and roll out any future improvements to Blueprint's layout engine, for example cross-layout caching, or further optimizations to the caffeinated layout contract.Next Steps
After this lands, I'll take care of deleting the now dead code from Market, and POS.