Adding peek support to PagedListLayout
#560
Merged
+615
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test and documentation cleanup.
…-items * johnnewman/feature/cache: Changelog updates. Updating actions cache version.
|
To ensure CI is working, this PR includes the actions/cache v4 changes from #561. |
johnnewman-square
force-pushed
the
johnnewman/feature/inset-items
branch
from
df39807 to
9d6e28e
Compare
johnnewman-square
force-pushed
the
johnnewman/feature/inset-items
branch
from
224474a to
70a3f32
Compare
maxg-square
reviewed
Mar 26, 2025
Demo/Sources/Demos/Demo Screens/AutoScrollingViewController.swift
Outdated
Show resolved
Hide resolved
maxg-square
reviewed
Mar 26, 2025
maxg-square
reviewed
Mar 26, 2025
maxg-square
reviewed
Mar 26, 2025
maxg-square
reviewed
Mar 26, 2025
ListableUI/Sources/Layout/ListLayout/ListLayoutScrollViewProperties.swift
Outdated
Show resolved
Hide resolved
maxg-square
reviewed
Mar 26, 2025
kyleve
reviewed
Mar 26, 2025
ListableUI/Sources/Layout/ListLayout/ListLayoutScrollViewProperties.swift
Outdated
Show resolved
Hide resolved
kyleve
reviewed
Mar 26, 2025
kyleve
reviewed
Mar 26, 2025
kyleve
reviewed
Mar 26, 2025
kyleve
approved these changes
Mar 26, 2025
nsillik
approved these changes
Mar 28, 2025
johnnewman-square
force-pushed
the
johnnewman/feature/inset-items
branch
from
8a2cab7 to
38e94c5
Compare
* main: Updating actions cache version (#561)
* main: Update run_tests.yml Update run_tests.yml Update run_tests.yml Update run_tests.yml Update run_tests.yml Update run_tests.yml Update env.properties Update run_tests.yml Prepare 15.0.2 release (#564) Update Xcode verison Update to use runner Add env var for macos runner Update SPM job to use env var Fix for crash when doing a programmatic scroll down while another external update is processed (#557) bug: Disable cell content interaction while swipe actions are visible. (#562)
1 task
johnnewman-square
added a commit
that referenced
this pull request
Apr 4, 2025
This release adds peek support for the `PagedListLayout` from #560.
1 task
kyleve
added a commit
that referenced
this pull request
Apr 15, 2025
In #560 we introduced a `percentageVisible` property on our list position info to support peek-based page layouts – this is usually fine, but due to event ordering, and namely how it takes an extra runloop for the collection view layout to update after `collectionView(_ collectionView: UICollectionView, moveItemAt from: IndexPath, to: IndexPath)` is called, we end up in a state where the list's storage is inconsistent with its layout. This means that our call to `ListStateObserver.perform(self.view.stateObserver.onItemReordered, "Item Reordered" ...)` would crash / be wrong until the layout occurred. The fix is to place the `Item Reordered` observer callback at the end of the update queue, so the collection view has time to "settle" internally and become consistent. [Relevant Slack Thread](https://square.slack.com/archives/CTJ4UNLHF/p1744750475867669) https://block.atlassian.net/browse/UI-8607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PagedListLayoutnow supports a peek value, which allows items to peek into view from the leading/top and trailing/bottom edges.PagingSizenow supportsinset(Peek)andfixed(CGFloat)page sizes.isPagingEnabledboolean with aPageScrollingBehaviorenum. This gives layouts the ability to disable paging, leveragefullUIScrollView paging (where items are full width), or usepeekpaging (where items can be less than the full width and peek into view).ListScrollPositionInfonow contains the percentage of visibility for each visible item. This allows clients to pick the most visible item for selection.Checklist
Please do the following before merging:
Mainsection.Simulator.Screen.Recording.-.iPad.mini.A17.Pro.-.2025-03-18.at.13.27.11.mp4