Changed WorkflowConcurrency Worker task priority to high #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabs-m
approved these changes
Oct 3, 2024
jamieQ
reviewed
Oct 3, 2024
mjohnson12
force-pushed
the
markj/concurrency_worker_task_priority
branch
from
322ea4c to
0ce2654
Compare
mjohnson12
changed the title
nabs-m
approved these changes
Oct 7, 2024
jamieQ
approved these changes
Oct 7, 2024
| @@ -63,7 +63,7 @@ struct WorkerWorkflow<WorkerType: Worker>: Workflow { | |||
| let sink = context.makeOutputSink() | |||
| context.runSideEffect(key: state) { lifetime in | |||
| let send: @MainActor(Output) -> Void = sink.send | |||
| let task = Task { | |||
| let task = Task(priority: .high) { | |||
There was a problem hiding this comment.
maybe add a note in one of the doc comments about this behavior
mjohnson12
force-pushed
the
markj/concurrency_worker_task_priority
branch
from
0ce2654 to
7a195b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist