Fixing RenderTester assert(action:) #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencochran
approved these changes
Aug 25, 2020
| @@ -38,7 +38,7 @@ extension AnyWorkflowConvertible { | |||
| /// | |||
| /// - Returns: The `Rendering` generated by the workflow. | |||
| public func rendered<Parent>(in context: RenderContext<Parent>, key: String = "") -> Rendering where Output: WorkflowAction, Output.WorkflowType == Parent { | |||
| return asAnyWorkflow().render(context: context, key: key, outputMap: { AnyWorkflowAction($0) }) | |||
| return asAnyWorkflow().render(context: context, key: key, outputMap: { $0 }) | |||
| } | |||
|
|
|||
| public func rendered<Parent, Action>(in context: RenderContext<Parent>, key: String = "", outputMap: @escaping (Output) -> Action) -> Rendering where Action: WorkflowAction, Action.WorkflowType == Parent { | |||
There was a problem hiding this comment.
The line below this too, yeah? (github won’t let me comment on collapsed parts of code…)
| @@ -98,6 +98,19 @@ final class WorkflowRenderTesterTests: XCTestCase { | |||
| .assertNoAction() | |||
| } | |||
|
|
|||
| func test_childWorkflowAction() { | |||
There was a problem hiding this comment.
Would this test fail before? I thought this only happened when things got AnyWorkflowd?
There was a problem hiding this comment.
This test did fail before the fix.
dhavalshreyas
force-pushed
the
dhaval/workflowAssertActionFix
branch
from
bd9e188 to
542fd03
Compare
AquaGeek
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
AnyWorkflowConvertiblewe were mapping all actions toAnyWorkflowAction. Fixing it here to map to a genericActiontype.Checklist