Updated info plugin to exclude guessed venv paths #8286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋,
since the amount of cases with minimal reproduction containing an inactive Virtual Environment reached a comfortable threshold I decided to update it and detect/guess possible venv paths.
To guess the paths I use the
pyvenv.cfg
file, which is added in the defaultpython -m venv
call:Perhaps other "venv" solutions don't do that, and a better alternative would be to use
site-packages
or look for "python" executables, but Linux might not usepython
but specifically somepython3.12
name variant, so I picked the simplest solution for now with thepyvenv.cfg
✌️9.6.14-guess.zip
In the final
platform.json
I decided to hide the username as it's a potential breach of privacy, a bit late after months but better late than never ✌️...
- in this case I obfuscated the username in the text here, however it would display for the user in the terminal.Additionally, I added the output of the
VIRTUAL_ENV
environmental variable to make sure we see the activated venv and don't have to guess based on thesys.path
Ref: