Automatically Request Channel Modes#1243
Merged
Merged
Conversation
…hannel mode is not sent by server/bouncer shortly after joining).
casperstorm
reviewed
Oct 17, 2025
| self.mode_requests.iter().position(|mode_request| { | ||
| mode_request.channel == target_channel | ||
| }) { | ||
| self.mode_requests.swap_remove(position); |
casperstorm
approved these changes
Oct 17, 2025
casperstorm
left a comment
casperstorm
left a comment
Member
There was a problem hiding this comment.
Works perfectly. Code is great as well.
This deserves a CHANGELOG entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically sends a mode request when joining a channel (if the channel mode is not sent by server/bouncer shortly after joining). The request response is used to populate channel metadata (to be able to show channel modes in the title bar and potentially elsewhere), and is otherwise hidden from the user.
Re-orders the tick logic a little bit to allow tick generated messages to enter the anti-flood message queue before it is processed.