Config editor buffer by casperstorm · Pull Request #2097 · squidowl/halloy

casperstorm · 2026-06-14T13:54:19Z

This introduces a config editor pane for easy edit of the config file.
You can ctrl(cmd)+s to save, and you can also press refresh or save in pane header.

initial work on text editor show proper error in footer add open config editor to keybind proper theming update command bar updated CHANGELOG better dark theme.

andymandias

I think this is really neat, should reduce friction for users who would rather not open a separate text editor (hopefully meaningfully so for such users), and is well integrated so we can use any benefits brought to it into the input box as well. Case in point, the undo/redo feature added as a side quest to this PR.

I have a few nits, but I think this is a very solid initial implementation.

andymandias · 2026-07-04T05:17:12Z

+            // Undo / redo
+            if key_press.modifiers.command() {
+                match key_press.key.as_ref() {
+                    iced::keyboard::Key::Character("z")
+                        if key_press.modifiers.shift() =>
+                    {
+                        return Some(text_editor::Binding::Custom(
+                            Message::Redo,
+                        ));
+                    }
+                    iced::keyboard::Key::Character("z") => {
+                        return Some(text_editor::Binding::Custom(
+                            Message::Undo,
+                        ));
+                    }
+                    iced::keyboard::Key::Character("y") => {
+                        return Some(text_editor::Binding::Custom(
+                            Message::Redo,
+                        ));
+                    }
+                    _ => {}
+                }
+            }
+


Should these be in text_editor_key_bindings?

andymandias · 2026-07-04T05:18:59Z

+fn kill_binding(
+    kill: text_editor_key_bindings::Kill,
+) -> text_editor::Binding<Message> {
+    text_editor::Binding::Custom(Message::Kill(kill, true))
 }

 #[cfg(target_os = "macos")]
 fn platform_specific_key_bindings(
    key_press: text_editor::KeyPress,
    selection: Option<&str>,
 ) -> Option<text_editor::Binding<Message>> {
    match key_press.key.as_ref() {
        iced::keyboard::Key::Named(iced::keyboard::key::Named::Backspace)
            if key_press.modifiers.alt() && selection.is_none() =>
        {
-            Some(text_editor::Binding::Custom(Message::DeleteWordBackward(
+            Some(text_editor::Binding::Custom(Message::Kill(
+                text_editor_key_bindings::Kill::WordBackward,
                false,
            )))
        }
        iced::keyboard::Key::Named(iced::keyboard::key::Named::Backspace)
            if key_press.modifiers.logo() && selection.is_none() =>
        {
-            Some(text_editor::Binding::Custom(Message::DeleteToStart(false)))
+            Some(text_editor::Binding::Custom(Message::Kill(
+                text_editor_key_bindings::Kill::ToStart,
+                false,
+            )))
        }
        iced::keyboard::Key::Named(iced::keyboard::key::Named::Delete)
            if key_press.modifiers.alt() =>
        {
-            Some(text_editor::Binding::Custom(Message::DeleteWordForward(
+            Some(text_editor::Binding::Custom(Message::Kill(
+                text_editor_key_bindings::Kill::WordForward,
                false,
            )))
        }
        iced::keyboard::Key::Named(iced::keyboard::key::Named::Delete)
            if key_press.modifiers.logo() =>
        {
-            Some(text_editor::Binding::Custom(Message::DeleteToEnd(false)))
+            Some(text_editor::Binding::Custom(Message::Kill(
+                text_editor_key_bindings::Kill::ToEnd,
+                false,
+            )))
        }
        // cmd+v routes to Message::Paste normally, which means we lose our control flow. overwrite it with our own handler
        iced::keyboard::Key::Character("v") if key_press.modifiers.logo() => {
            Some(text_editor::Binding::Custom(Message::Paste))
        }
        _ => None,
    }
 }

 #[cfg(not(target_os = "macos"))]
 fn platform_specific_key_bindings(
    key_press: text_editor::KeyPress,
    selection: Option<&str>,
 ) -> Option<text_editor::Binding<Message>> {
    match key_press.key.as_ref() {
        iced::keyboard::Key::Named(iced::keyboard::key::Named::Backspace)
            if key_press.modifiers.control() && selection.is_none() =>
        {
            if key_press.modifiers.shift() {
-                Some(text_editor::Binding::Custom(Message::DeleteToStart(
+                Some(text_editor::Binding::Custom(Message::Kill(
+                    text_editor_key_bindings::Kill::ToStart,
                    false,
                )))
            } else {
-                Some(text_editor::Binding::Custom(Message::DeleteWordBackward(
+                Some(text_editor::Binding::Custom(Message::Kill(
+                    text_editor_key_bindings::Kill::WordBackward,
                    false,
                )))
            }
        }
        iced::keyboard::Key::Named(iced::keyboard::key::Named::Delete)
            if key_press.modifiers.control() =>
        {
            if key_press.modifiers.shift() {
-                Some(text_editor::Binding::Custom(Message::DeleteToEnd(false)))
+                Some(text_editor::Binding::Custom(Message::Kill(
+                    text_editor_key_bindings::Kill::ToEnd,
+                    false,
+                )))
            } else {
-                Some(text_editor::Binding::Custom(Message::DeleteWordForward(
+                Some(text_editor::Binding::Custom(Message::Kill(
+                    text_editor_key_bindings::Kill::WordForward,
                    false,
                )))
            }
        }
        iced::keyboard::Key::Named(iced::keyboard::key::Named::Insert)
            if key_press.modifiers.shift() && key_press.text.is_none() =>
        {
            Some(text_editor::Binding::Custom(Message::Paste))
        }
        // ctrl+v routes to Message::Paste normally, which means we lose our control flow. overwrite it with our own handler
        iced::keyboard::Key::Character("v")
            if key_press.modifiers.control() =>
        {
            Some(text_editor::Binding::Custom(Message::Paste))
        }

        _ => None,
    }
 }


Would it make sense to put these inside the text_editor_key_bindings module, so they could be re-used in the config editor?

andymandias · 2026-07-04T05:44:19Z

-            | Buffer::ChannelDiscovery(_) => Task::none(),
+            | Buffer::ChannelDiscovery(_)
+            | Buffer::ConfigEditor(_) => Task::none(),


I think we should pass PageUp to the config editor. Similarly with scroll_down_page. Otherwise, PageUp/PageDown are inoperable in the Config Editor by default (in Linux/Windows).

andymandias · 2026-07-04T05:44:55Z

 Added:

 - Internal buffers (logs, highlights, etc) can be added to sidebar
+- Config editor pane for editing the config file in-app


We should add an entry for undo/redo. Very nice feature addition that needs a shout out.

andymandias · 2026-07-04T05:54:56Z

            | Buffer::FileTransfers(_)
-            | Buffer::ChannelDiscovery(_) => Task::none(),
+            | Buffer::ChannelDiscovery(_)
+            | Buffer::ConfigEditor(_) => Task::none(),


Similar to page-up/down, I think this should work in the config editor to scroll to the bottom of the file (and scroll_to_start should scroll to the top of the file).

casperstorm force-pushed the pane/text_editor branch 2 times, most recently from 81436f4 to 57912d4 Compare June 15, 2026 19:47

andymandias force-pushed the pane/text_editor branch 2 times, most recently from ad60d28 to cc1e0ba Compare June 16, 2026 17:36

casperstorm force-pushed the pane/text_editor branch 2 times, most recently from 1767839 to 6669278 Compare June 19, 2026 20:53

andymandias force-pushed the pane/text_editor branch from 6669278 to d29c72f Compare June 20, 2026 03:28

casperstorm and others added 10 commits July 3, 2026 14:00

config text editor

6d71316

initial work on text editor show proper error in footer add open config editor to keybind proper theming update command bar updated CHANGELOG better dark theme.

support redo-undo

8bd5ee9

generalize redo/undo

22123a0

Minor fix for TextColorSvg utilization.

894437b

generalized emacs shortcuts for all text editors

0bc990a

show keybind in tooltip

600ea82

better handle unsaved changes

825bb84

section inside bottom space

0804ddb

Neglected Cargo.lock update.

f844ff7

Ensure status line stays a single line.

b83e8e1

andymandias force-pushed the pane/text_editor branch from 1a57ac7 to b83e8e1 Compare July 4, 2026 05:22

andymandias approved these changes Jul 4, 2026

View reviewed changes

andymandias linked an issue Jul 4, 2026 that may be closed by this pull request

[feature request] text input ctrl + z/y undo/redo #211

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Config editor buffer#2097

Config editor buffer#2097
casperstorm wants to merge 10 commits into
mainfrom
pane/text_editor

casperstorm commented Jun 14, 2026 •

edited

Loading

Uh oh!

andymandias left a comment

Uh oh!

andymandias Jul 4, 2026

Uh oh!

andymandias Jul 4, 2026

Uh oh!

andymandias Jul 4, 2026

Uh oh!

andymandias Jul 4, 2026

Uh oh!

andymandias Jul 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

casperstorm commented Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andymandias left a comment

Choose a reason for hiding this comment

Uh oh!

andymandias Jul 4, 2026

Choose a reason for hiding this comment

Uh oh!

andymandias Jul 4, 2026

Choose a reason for hiding this comment

Uh oh!

andymandias Jul 4, 2026

Choose a reason for hiding this comment

Uh oh!

andymandias Jul 4, 2026

Choose a reason for hiding this comment

Uh oh!

andymandias Jul 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

casperstorm commented Jun 14, 2026 •

edited

Loading